You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR addresses parts of related issues like #2240#2241
Addresses the issue in full
Addresses only certain aspects of the issue
Description
In our public site forms, we should not have repeated links with the same text without an appropriate aria label that gives context. Buttons with the same IDs can also cause issues with screen readers.
This PR also turns the housing members page into a list so it's clear there will be repeated sections.
How Can This Be Tested/Reviewed?
With a screen reader on, you can navigate through the household members page and hear it read the members as a list, or visit the application summary page and hear the new labels on the Edit links.
Author Checklist:
Added QA notes to the issue with applicable URLs
Reviewed in a desktop view
Reviewed in a mobile view
Reviewed considering accessibility
Added tests covering the changes
Made corresponding changes to the documentation
Ran yarn generate:client and/or created a migration when required
Review Process:
Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a11yAn accessibility bugready to mergeShould be applied when a PR has been reviewed and approved
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emilyjablonski
added
a11y
ludtkemorgan
added
ready to merge
This PR addresses parts of related issues like #2240 #2241
Description
In our public site forms, we should not have repeated links with the same text without an appropriate aria label that gives context. Buttons with the same IDs can also cause issues with screen readers.
This PR also turns the housing members page into a list so it's clear there will be repeated sections.
How Can This Be Tested/Reviewed?
With a screen reader on, you can navigate through the household members page and hear it read the members as a list, or visit the application summary page and hear the new labels on the Edit links.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: